fix(workspace): harden runbook init template embed filter (#325)#71
Open
advancedresearcharray wants to merge 4 commits into
Open
fix(workspace): harden runbook init template embed filter (#325)#71advancedresearcharray wants to merge 4 commits into
advancedresearcharray wants to merge 4 commits into
Conversation
…-03) Re-confirms UC-6 runbook scaffold, schema validation, and kiwifs check regression tests before fleet PR closing kiwifs#325. Co-authored-by: Cursor <cursoragent@cursor.com>
Filter dev-only template paths from go:embed so kiwifs init --template runbook stays lint-clean. Add service stubs for example runbook wiki links and regression tests for embed visibility and scaffold paths. Closes kiwifs#325 Co-authored-by: Cursor <cursoragent@cursor.com>
Wire service stubs and playbook into index.md so kiwifs check reports fewer orphan info issues on generated runbook scaffolds. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
filteredTemplatesFSto exclude dev-only legacy template paths fromgo:embedsokiwifs init --template runbookstays lint-cleanservices/api-service.md,services/monitoring.md) as wiki-link targets for the example runbookkiwifs checkon generated workspaceCloses kiwifs#325
Test plan
go test ./internal/workspace/... -count=1 -run 'Runbook|Embed|Filtered'go test ./cmd/... -count=1 -run 'Runbook'TestRunbookInitCheckPasses—kiwifs checkexits 0 on scaffold (info-level orphans only)TestRunbookEmbedUsesUC6ScaffoldOnly— legacy paths hidden from embedtrigger,severity,owner,services)Made with Cursor